Skip to content

Cleanup multiapi package generation (along with doc refs). #41943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

Cleanup multiapi package generation (along with doc refs). #41943

merged 2 commits into from
Jul 10, 2025
+4 −559

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Jul 8, 2025 •
edited
Loading

@msyyc Hey Yuchao, a bit delayed, but this is the cleanup PR I promised on that pkg_resources PR week before last.

Can you please take a look at the scripts directory and let me know if there are any scripts in there that you no longer use? I'd like to really clean up these directories as I intend to move all of our tools/ and scripts/ under the eng folder per our repo guidelines.

@scbedd scbedd self-assigned this Jul 8, 2025
@Copilot Copilot AI review requested due to automatic review settings July 8, 2025 18:14
@scbedd scbedd requested a review from mccoyp as a code owner July 8, 2025 18:14
@scbedd scbedd moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🔨🏗️💻🚧 Jul 8, 2025
Copilot
Copilot AI reviewed Jul 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Cleanup of the multi-API generation tooling and related documentation references, as part of consolidating scripts under the eng/ folder.

  • Removed the standalone multiapi_init_gen.py script
  • Deleted outdated doc references to multi-API client regeneration
  • Streamlined package-version rules by dropping the multi-API note

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
scripts/multiapi_init_gen.py Deleted unused multi-API init generator script
doc/dev/package_version/package_version_rule.md Removed obsolete multi-API reference note
doc/dev/mgmt/cheatsheet.md Removed multi-API regeneration commands from cheat sheet

msyyc
msyyc approved these changes Jul 9, 2025 •
edited
Loading
View reviewed changes
@msyyc
Copy link
Member

msyyc commented Jul 9, 2025

Hi @scbedd, thanks for the inform. Yeah, I write some scripts under scripts folder including:

  • auto_release
  • issue_helper
  • multiapi-configuration-helper
  • quickstart_tooling_dpg
  • release_helper
  • release_sdk_staus
  • automation_generate.sh
  • automation_init.sh

release_sdk_staus is not used anymore but others are still in use. By the way, please ping me when we make the PR to move the scripts since there are some pipelines based on the scripts and I need to make some adjust when the folder changes.

@scbedd
Copy link
Member Author

scbedd commented Jul 9, 2025

Hi @scbedd, thanks for the inform. Yeah, I write some scripts under scripts folder including:

  • auto_release
  • issue_helper
  • multiapi-configuration-helper
  • quickstart_tooling_dpg
  • release_helper
  • release_sdk_staus
  • automation_generate.sh
  • automation_init.sh

release_sdk_staus is not used anymore but others are still in use. By the way, please ping me when we make the PR to move the scripts since there are some pipelines based on the scripts and I need to make some adjust when the folder changes.

Absolutely. I'll make certain you're on all the PRs.

@scbedd scbedd merged commit 70db1ec into Azure:main Jul 10, 2025
16 checks passed
@scbedd scbedd deleted the cleanup-multiapi-gen branch July 10, 2025 00:06
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🔨🏗️💻🚧 Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@mccoyp mccoyp mccoyp approved these changes

@msyyc msyyc msyyc approved these changes

Assignees

@scbedd scbedd

Labels
None yet
Projects
Azure SDK EngSys 🔨🏗️💻🚧
Status: 🎊 Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scbedd @msyyc @mccoyp